Skip to content

[SPARK-11210][SPARKR] Add window functions into SparkR [step 2].#9196

Closed
sun-rui wants to merge 2 commits intoapache:masterfrom
sun-rui:SPARK-11210
Closed

[SPARK-11210][SPARKR] Add window functions into SparkR [step 2].#9196
sun-rui wants to merge 2 commits intoapache:masterfrom
sun-rui:SPARK-11210

Conversation

@sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Oct 21, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Oct 21, 2015

Test build #44055 has finished for PR 9196 at commit e746583.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

felixcheung commented Oct 21, 2015

This is merging 2 PR/JIRA?

@sun-rui
Copy link
Contributor Author

sun-rui commented Oct 22, 2015

@felixcheung , this is a WIP as a successive step based on the previous PR for SPARK-11209 which has not been merged. After the PR for SPARK-11209 is merged, I will rebase this PR to master branch.

@sun-rui
Copy link
Contributor Author

sun-rui commented Oct 22, 2015

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Oct 22, 2015

Test build #44122 has finished for PR 9196 at commit e746583.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sun-rui
Copy link
Contributor Author

sun-rui commented Oct 27, 2015

Rebased to master

@sun-rui sun-rui changed the title [SPARK-11210][SPARKR][WIP] Add window functions into SparkR [step 2]. [SPARK-11210][SPARKR] Add window functions into SparkR [step 2]. Oct 27, 2015
@SparkQA
Copy link

SparkQA commented Oct 27, 2015

Test build #44404 has finished for PR 9196 at commit 2e84e2d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaCountVectorizerExample\n * public class JavaTfIdfExample\n * public class JavaWord2VecExample\n

@felixcheung
Copy link
Member

felixcheung commented Oct 27, 2015

looks good!

shivaram
shivaram reviewed Oct 27, 2015
View reviewed changes
R/pkg/R/functions.R
Copy link
Contributor

@shivaram shivaram Oct 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rank seems like a more common r function. Are there any alternate ideas for names here ?

Copy link
Contributor Author

@sun-rui sun-rui Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since base::rank() has a different signature with this rank(), it is possible to expose both of them under the same name rank().

@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44523 has finished for PR 9196 at commit b52a98d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Oct 30, 2015

LGTM. Merging this. Thanks @sun-rui

@asfgit asfgit closed this in 40c77fb Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sun-rui @SparkQA @felixcheung @shivaram